Jump to content

 

matthew.erwin

Member Since 18 Jun 2015
Offline Last Active Apr 30 2018 01:30 PM
*****

Posts I've Made

In Topic: Adapt Your Add-Ons And Themes To 4.3.5

17 December 2015 - 02:01 PM

Hi Guys,

 

What is the method used for versioning updates?

 

According to SemVer, this release should have been a minor version (v4.4.0) since a number of new features and hooks have been added.

 

Thanks.


In Topic: [Suggestion] Provide More Parameters In Fn_Execute_Permission_Condition

24 October 2015 - 11:24 AM

Those should all be available to you in the Registry::get('runtime') array or via $_SERVER variables.  No need to pass them as parameters if they can be referenced from memory.

 

When the view is parsed to determine which admin menu items should be shown in fn_check_view_permissions, those variables are not available as Registry::get('runtime') will only return the page that you are on, not the page you wish to check.


In Topic: Your Add-On Needs A New Hook In Cs-Cart. Post It Here.

14 October 2015 - 07:49 AM

Will be done in 4.3.5

There will be too hooks:

fn_set_hook('save_cart_pre', $cart, $user_id, $type, $user_type); - in the begining of the function

fn_set_hook('save_cart_post', $cart, $user_id, $type, $user_type, $_cart_prods); - just before the line "return true";

'save_cart' hook will be depricated, but will still be available until 5.x.x

 

 

Planned for 4.3.5

There will be ability to change popularity and order_details arrays before the Insert query.

 

That's great. Thanks!


In Topic: Your Add-On Needs A New Hook In Cs-Cart. Post It Here.

03 September 2015 - 01:12 PM

Hi tbirnseth, thanks for your reply.

 

I have used the code you provided, although it does require an extra unnecessary database query when the data is already readily available in the code therefore it would still make sense for it to be passed through in the hook.

 

-------------------------------------------------------------

 

Another hook suggestion for fn_create_order_details:

 

v4.3.1 app/functions/fn.cart.php:1093

fn_set_hook('create_order_details', $order_id, $cart, $order_details);

Thanks


In Topic: Your Add-On Needs A New Hook In Cs-Cart. Post It Here.

26 August 2015 - 08:56 AM

Not a new hook, just an extra parameter added to an existing one.

 

save_cart should also include the $user_type variable.

 

So 

fn_set_hook('save_cart', $cart, $user_id, $type);

would become

fn_set_hook('save_cart', $cart, $user_id, $type, $user_type);

in app/functions/fn.cart.php:1472

 

Thanks!