Jump to content

  • You cannot start a new topic
  • You cannot reply to this topic

Issue With Php 7.3 Rate Topic   - - - - -

 
  • ankita
  • Member
  • Trial users
  • Join Date: 19-May 16
  • 20 posts

Posted 17 May 2019 - 05:33 AM #1

Hi,

I am using recent version MV 493 with php 7.3.5 and facing issue in lib.Please help. 

https://prnt.sc/npnkw2 

 

Thanks, 



 
  • soft-solid
  • Junior Member
  • Members
  • Join Date: 19-Apr 10
  • 690 posts

Posted 17 May 2019 - 08:25 PM #2

Hello ankita

 

This is problem with using PCRE2 in PHP 7.3. The new PCRE2 library is more aggressive in pattern validation.

If you want to correct it yourself, change it

 

class="[\w- ]

 

on:

 

class="[\w\- ]

 

in file /app/functions/smarty_plugins/modifier.empty_tabs.php in line 30

 

Best regards

Robert


Team of SoftSolid
cs-cart.pl

 
  • mumbomedia
  • Advanced Member
  • Members
  • Join Date: 13-Jan 17
  • 77 posts

Posted 22 May 2019 - 08:15 AM #3

It's not smart to run PHP 7.3 since it's officially not supported!



 
  • poppedweb
  • Authorized Reseller
  • Members
  • Join Date: 02-Aug 16
  • 512 posts

Posted 22 May 2019 - 10:14 AM #4

It's not smart to run PHP 7.3 since it's officially not supported!

 

When looking at the code changes, it seems to be planned for 4.10, which is completely expected.

 

Besides that, PHP 7.4 is already on the horizon with more optimizations and way better performance. For those who are interested, it brings the following things to the table:

- Strict typing for classes;

- Preloading

- Improved type variance

- Short closures for better one-line functions

 

There only seem to be 2 things that are considered breaking changes here as well, which is good news:

- Short open tags are deprecated;

- The left associative ternary operator is now deprecated. This will require a lot of reworking in the core since it is used a lot.

 

And with all of that it will again be 30% to even 50% in most scenarios. So it's definitely something you should look out for!


PoppedWeb | sales@poppedweb.com | https://poppedweb.com
TurnKey Website Design | Add-Ons | Performance Audits | Dedicated Server Management
24/7 Support | Response within an hour (during working hours).