Jump to content

  • You cannot start a new topic
  • You cannot reply to this topic

Free Addon To Fix The Recent Http/2 Bug Rate Topic   * * * * * 1 votes

 
  • tbirnseth
  • CS Cart Expert
  • Authorized Reseller
  • Join Date: 08-Nov 08
  • 11365 posts

Posted 17 November 2018 - 12:15 AM #1

All services that use Google API's now respond with HTTP/2 headers (Paypal, Recaptcha, etc.).  They will fail in cs-cart (though responses to your browser will succeed - I.e. Javascript).  For instance Recaptcha will return a green checkmark, but then you'll get a message that the code is invalid when you try to proceed.

 

 

Since cs-cart is not willing to generate an addon to patch this issue on their product, I built an addon that will address the problem and apply the patch.  It will patch any site that has app/Tygh/Http.php where the HTTP/2 header fix is not applied.

 

You can download the addon at: https://ez-ms.com/pr...p2_fix_v1.0.zip


EZ Merchant Solutions: Custom (USA based) B2B Development, Consulting, Development and Special Projects (get a quote here).
Commercial addons, payment methods and modifications to meet your business and operations needs.


 
  • brandonvd
  • is Super Awesome
  • Members
  • Join Date: 19-Dec 06
  • 2633 posts

Posted 17 November 2018 - 03:12 AM #2

Hey Tony. I'm getting a 404 with that URL. Can you please check it?



 
  • eComLabs
  • CS-Cart Expert
  • Authorized Reseller
  • Join Date: 27-Jan 14
  • 19709 posts

Posted 19 November 2018 - 06:55 AM #3

Please use the following URL

 

https://ez-ms.com/pr...p2_fix_v1.0.zip


GET A FREE QUOTE | CS-Cart Add-ons | CS-Cart Licenses | CS-Cart Development | CS-Cart Design | Server Configuration | UniTheme and YOUPI
CS-Cart                USD 345     Multi-Vendor              USD 1250    CS-Cart RU                         24500 руб.
CS-Cart Ultimate  USD 775     CS-Cart + YOUPI      USD 545      CS-Cart RU + UniTheme    36000 руб.


 
  • tbirnseth
  • CS Cart Expert
  • Authorized Reseller
  • Join Date: 08-Nov 08
  • 11365 posts

Posted 19 November 2018 - 07:12 PM #4

Hey Tony. I'm getting a 404 with that URL. Can you please check it?

Sorry about that.  Had a '.' instead of '_' in the path.  I've updated the original post.


EZ Merchant Solutions: Custom (USA based) B2B Development, Consulting, Development and Special Projects (get a quote here).
Commercial addons, payment methods and modifications to meet your business and operations needs.


 
  • discodud
  • Member
  • Members
  • Join Date: 12-Feb 18
  • 15 posts

Posted 03 May 2019 - 10:52 AM #5

Hi Tony

CSC 4.7.1

I installed your addon in the hope that it will fix my Lighthouse http/2 errors. Unfortunately it did not, and in testing my website post addon installation, and clearing cache, I am told that I do not have http/2 running. Is there anything I may have done wrong, or perhaps it does not work for my version?

I get a message whenever I logon to say there have been core file changes...?

Perhaps I am misunderstanding the function of the adddon.



 
  • tbirnseth
  • CS Cart Expert
  • Authorized Reseller
  • Join Date: 08-Nov 08
  • 11365 posts

Posted 03 May 2019 - 04:32 PM #6

I don't have access to a 4.7 site to review.  It's a pretty simple change and only deals with headers returned from requests.  It's not YOU who use http/2, but whomever you are making the request to.  They are responding with a header not recognized in your version of cs-cart. This simply adds the handling of that header to let their response complete.


EZ Merchant Solutions: Custom (USA based) B2B Development, Consulting, Development and Special Projects (get a quote here).
Commercial addons, payment methods and modifications to meet your business and operations needs.


 
  • discodud
  • Member
  • Members
  • Join Date: 12-Feb 18
  • 15 posts

Posted 03 May 2019 - 09:37 PM #7

Thank you, I clearly misunderstood it's purpose. So much to learn! 

 

When I do a lighthouse evaluation on my site it comes up with "30 requests not served via http/2", which helping to kill my "best Practice" score. Is there anything that I can do to address this or is it beyond my control? This is what I had thought your addon would remedy.



 
  • tbirnseth
  • CS Cart Expert
  • Authorized Reseller
  • Join Date: 08-Nov 08
  • 11365 posts

Posted 03 May 2019 - 09:52 PM #8

I have no idea what lighthouse is doing or expecting.


EZ Merchant Solutions: Custom (USA based) B2B Development, Consulting, Development and Special Projects (get a quote here).
Commercial addons, payment methods and modifications to meet your business and operations needs.