[memel]

Hello,

 

I have added autoresponder to subscribers to confirm subscription. But the confirmation link %ACTIVATION_LINK added without HTTPS. Website has ssl and configured to HTTPS. Please see the picture below:

 

 

And if you click in google mail the link, getting warning:

 

 

Second question: is emails still sending to those subscribers who didn't activated, as I can see them in subscription list?

[eComLabs]

app/addons/newsletters/func.php

 

find the fn_generate_activation_link function and replace

return fn_url("newsletters.activate?list_id=$list_id&key=$activation_key&s_id=$subscriber_id", 'C', 'http');

with

return fn_url("newsletters.activate?list_id=$list_id&key=$activation_key&s_id=$subscriber_id", 'C', 'https');

[tbirnseth]

I would suggest using 'current' instead of either 'http' or 'htpps' since that will follow the current page protocol regardless of what it is.

[eComLabs]

I would suggest using 'current' instead of either 'http' or 'htpps' since that will follow the current page protocol regardless of what it is.

 

'current' is also not right since only admin panel can be https. In the core it should be 

fn_get_storefront_protocol()

But to solve memel's issue, 'https' is also ok

[memel]

 Thank you for help all of you.

[tbirnseth]

'current' is also not right since only admin panel can be https. In the core it should be 

fn_get_storefront_protocol()

But to solve memel's issue, 'https' is also ok

Hmm, not really looked deeply, but since 'C' is specified as the AREA, I would expect (maybe naively) that 'current" would indeed get the valid customer area setting for HTTP protocol.

[eComLabs]

Hmm, not really looked deeply, but since 'C' is specified as the AREA, I would expect (maybe naively) that 'current" would indeed get the valid customer area setting for HTTP protocol.

 

 

I am afraid, it will create store-front URL with admin panel protocol

[tbirnseth]

I am afraid, it will create store-front URL with admin panel protocol

To me, that's a bug. Why specify the AREA if it's going to be ignored?

[eComLabs]

Just because different parameters are responsible for different functionality

[tbirnseth]

Well, we could probably have design discussions all day long. But seems to me if an AREA is specified, then that AREA should be used to determine the context of any action.  Not just for whether to use customer/admin templates.