Jump to content

  • You cannot start a new topic
  • You cannot reply to this topic

Email Autoresponder Rate Topic   - - - - -

 
  • memel
  • Senior Member
  • Members
  • Join Date: 29-May 17
  • 212 posts

Posted 22 September 2018 - 10:08 AM #1

Hello,

 

I have added autoresponder to subscribers to confirm subscription. But the confirmation link %ACTIVATION_LINK added without HTTPS. Website has ssl and configured to HTTPS. Please see the picture below:

 

2018-09-22_10h51_42.png

 

And if you click in google mail the link, getting warning:

 

2018-09-22_10h53_47.png

 

Second question: is emails still sending to those subscribers who didn't activated, as I can see them in subscription list?



 
  • eComLabs
  • CS-Cart Expert
  • Authorized Reseller
  • Join Date: 27-Jan 14
  • 19782 posts

Posted 24 September 2018 - 06:04 AM #2

app/addons/newsletters/func.php

 

find the fn_generate_activation_link function and replace

return fn_url("newsletters.activate?list_id=$list_id&key=$activation_key&s_id=$subscriber_id", 'C', 'http');

with

return fn_url("newsletters.activate?list_id=$list_id&key=$activation_key&s_id=$subscriber_id", 'C', 'https');

GET A FREE QUOTE | CS-Cart Add-ons | CS-Cart Licenses | CS-Cart Development | CS-Cart Design | Server Configuration | UniTheme and YOUPI
CS-Cart                USD 345     Multi-Vendor              USD 1250    CS-Cart RU                         24500 руб.
CS-Cart Ultimate  USD 775     CS-Cart + YOUPI      USD 545      CS-Cart RU + UniTheme    36000 руб.


 
  • tbirnseth
  • CS Cart Expert
  • Authorized Reseller
  • Join Date: 08-Nov 08
  • 11392 posts

Posted 24 September 2018 - 08:55 PM #3

I would suggest using 'current' instead of either 'http' or 'htpps' since that will follow the current page protocol regardless of what it is.


EZ Merchant Solutions: Custom (USA based) B2B Development, Consulting, Development and Special Projects (get a quote here).
Commercial addons, payment methods and modifications to meet your business and operations needs.


 
  • eComLabs
  • CS-Cart Expert
  • Authorized Reseller
  • Join Date: 27-Jan 14
  • 19782 posts

Posted 25 September 2018 - 05:37 AM #4

I would suggest using 'current' instead of either 'http' or 'htpps' since that will follow the current page protocol regardless of what it is.

 

'current' is also not right since only admin panel can be https. In the core it should be 

fn_get_storefront_protocol()

But to solve memel's issue, 'https' is also ok


GET A FREE QUOTE | CS-Cart Add-ons | CS-Cart Licenses | CS-Cart Development | CS-Cart Design | Server Configuration | UniTheme and YOUPI
CS-Cart                USD 345     Multi-Vendor              USD 1250    CS-Cart RU                         24500 руб.
CS-Cart Ultimate  USD 775     CS-Cart + YOUPI      USD 545      CS-Cart RU + UniTheme    36000 руб.


 
  • memel
  • Senior Member
  • Members
  • Join Date: 29-May 17
  • 212 posts

Posted 25 September 2018 - 07:23 AM #5


 Thank you for help all of you.



 
  • tbirnseth
  • CS Cart Expert
  • Authorized Reseller
  • Join Date: 08-Nov 08
  • 11392 posts

Posted 25 September 2018 - 08:33 PM #6

'current' is also not right since only admin panel can be https. In the core it should be 

fn_get_storefront_protocol()

But to solve memel's issue, 'https' is also ok

Hmm, not really looked deeply, but since 'C' is specified as the AREA, I would expect (maybe naively) that 'current" would indeed get the valid customer area setting for HTTP protocol.


EZ Merchant Solutions: Custom (USA based) B2B Development, Consulting, Development and Special Projects (get a quote here).
Commercial addons, payment methods and modifications to meet your business and operations needs.


 
  • eComLabs
  • CS-Cart Expert
  • Authorized Reseller
  • Join Date: 27-Jan 14
  • 19782 posts

Posted 26 September 2018 - 06:49 AM #7

Hmm, not really looked deeply, but since 'C' is specified as the AREA, I would expect (maybe naively) that 'current" would indeed get the valid customer area setting for HTTP protocol.

 

 

I am afraid, it will create store-front URL with admin panel protocol


GET A FREE QUOTE | CS-Cart Add-ons | CS-Cart Licenses | CS-Cart Development | CS-Cart Design | Server Configuration | UniTheme and YOUPI
CS-Cart                USD 345     Multi-Vendor              USD 1250    CS-Cart RU                         24500 руб.
CS-Cart Ultimate  USD 775     CS-Cart + YOUPI      USD 545      CS-Cart RU + UniTheme    36000 руб.


 
  • tbirnseth
  • CS Cart Expert
  • Authorized Reseller
  • Join Date: 08-Nov 08
  • 11392 posts

Posted 26 September 2018 - 05:02 PM #8

I am afraid, it will create store-front URL with admin panel protocol

To me, that's a bug. Why specify the AREA if it's going to be ignored?


EZ Merchant Solutions: Custom (USA based) B2B Development, Consulting, Development and Special Projects (get a quote here).
Commercial addons, payment methods and modifications to meet your business and operations needs.


 
  • eComLabs
  • CS-Cart Expert
  • Authorized Reseller
  • Join Date: 27-Jan 14
  • 19782 posts

Posted 27 September 2018 - 06:15 AM #9

Just because different parameters are responsible for different functionality


GET A FREE QUOTE | CS-Cart Add-ons | CS-Cart Licenses | CS-Cart Development | CS-Cart Design | Server Configuration | UniTheme and YOUPI
CS-Cart                USD 345     Multi-Vendor              USD 1250    CS-Cart RU                         24500 руб.
CS-Cart Ultimate  USD 775     CS-Cart + YOUPI      USD 545      CS-Cart RU + UniTheme    36000 руб.


 
  • tbirnseth
  • CS Cart Expert
  • Authorized Reseller
  • Join Date: 08-Nov 08
  • 11392 posts

Posted 27 September 2018 - 06:27 PM #10

Well, we could probably have design discussions all day long. But seems to me if an AREA is specified, then that AREA should be used to determine the context of any action.  Not just for whether to use customer/admin templates.


EZ Merchant Solutions: Custom (USA based) B2B Development, Consulting, Development and Special Projects (get a quote here).
Commercial addons, payment methods and modifications to meet your business and operations needs.