Thickbox mod for V1.3.4 r2

You shouldnt need to change the pop_up.tpl any more…



Its basically been removed from being referenced atall…



I restored mine from repository and there was no difference in the workings !

Isn’t this line:



new_ref[id] = ""+pr_i[id][row]['detailed2']+""




Missing an ; at the end?





Hmm, odd behavior. Keep pressing prev and next links a couple of times. The product name seems to randomly dissapear and appear.

No… there wasnt one in the original code either…



My code is like this :



function fn_change_image(id, row)

{

if (pr_i[id][row][‘detailed_id’] != ‘0’) {



new_ref[id] = “”+pr_i[id][row][‘detailed2’]+“”



// new_ref[id] = “”+image_index+“?object_type=detailed&image_id=”+pr_i[id][row][‘detailed_id’]+“”



if (document.getElementById(‘detailed_href1_’ + id)) {

document.getElementById(‘detailed_href1_’ + id).href = new_ref[id];

}



Ignore the commented line, for memory purposes hehe

Theres something not quite right on your image.tpl



Ive attached mine below try it with this !

image.tpl.txt

This is annoying. :stuck_out_tongue:



Are you sure you didn’t miss adding any small changes you’ve made to the first post?



I can’t figure it out. I’ll investigate it further tomorrow.



Thanks.

You’re right, there is something wrong in my image.tpl, I have modified it before aswell so might be something interfering. I tried yours and it seems to work.



I’ll check it out tomorrow.



After I find that it should work!



Thanks!

Ive attached my exceptions.js and product_options.tpl files below



I have only added thickbox to these files, no other mods so if yours hasnt been modded will be ok to over write.



Make a copy of yours first though



Looking at your site, the link isnt changing with the dynamic options so it must be somewhere in one of these files…

2_files_above.zip

Check it out, it’s pimping right now! :wink:



This mod rules!

Got there in the end :slight_smile: :smiley: :smiley: :wink:



Spot on… seems to be working perfectly !

i know it is really cool. again, thank you for putting the time into making this happen.



the next step: terms and conditions =)


[quote name=‘SWS’]Looking good Mpjbay



You gotta love this mod… makes all your images look like polaroids ![/QUOTE]

so all works but one thing.



the product name doesn’t load on mine. it is no big deal because i incorporated the name into the slides anyway.



just fyi



=)

[quote name=‘mpjbay’]so all works but one thing.



the product name doesn’t load on mine. it is no big deal because i incorporated the name into the slides anyway.



just fyi



=)[/quote]



Just had a look at your site quickly, you have a javascript error, check the exceptions.js file (download from my archive above)



I will double check my code on front page tommorow but mine doesnt generate this error

I replaced my exceptions.js with yours and I double checked my code (it is the same as yours) and the product name still doesn’t load but the funny thing is that when I clcik “back” the product name populates. funny =)


[quote name=‘SWS’]Just had a look at your site quickly, you have a javascript error, check the exceptions.js file (download from my archive above)



I will double check my code on front page tommorow but mine doesnt generate this error[/QUOTE]

[quote name=‘mpjbay’]I replaced my exceptions.js with yours and I double checked my code (it is the same as yours) and the product name still doesn’t load but the funny thing is that when I clcik “back” the product name populates. funny =)[/QUOTE]



I had this problem aswell. Check your image.tpl file, try using the same as SWS. And also use the original popup_image.tpl from default_blue and see if the problem still occurs.

i will give that a go. did it fix the issue you were having?


[quote name=‘mpjbay’]i will give that a go. did it fix the issue you were having?[/QUOTE]



Yes, my template file was modified since earlier which caused a problem.

i replaced the popup_image.tpl and checked the code on image.tpl and still having the same issue.



could you up your image.tpl? i may have missed something. (i am using default_blue as well)



=)

Matt


Thank you for putting the time and for sharing this. It works perfectly.

Dont forget to install the animated GIF, a posts up from here !

and of course, No problem… Ill contribute where I can !

I’ve just added the ThickBox mod as per SWS instructions and must say I love the modifications.



At the present moment if I click upon the image located at this page :

[url]http://southeastauto.com.au/air-flow-meter-air-mass-sensor-p77.html[/url]



[COLOR=“Blue”]In FireFox 2.0 Mod works perfectly.[/COLOR]

[url]http://southeastauto.com.au/air-flow-meter-air-mass-sensor-p77.html[/url]

[COLOR=“Red”]

In IE 7 however I get redirected to[/COLOR]

[url]http://southeastauto.com.au/images/detailed_images/err7171.jpg[/url]



As mentioned prior by mpjbay, I have the exact same situation however cannot seem to find a fix anywhere in this thread.

[quote name=‘mpjbay’]

4. some of the pictures do not open in thickbox but gets redirected to a blank html page with a thumb[/QUOTE]



Is there a fix posted or have I overlooked it?

Here are the files [ATTACH]288[/ATTACH] that I have taken from Skin :

Brickwork_dark_steel and have modified accordingly to SWS’s posts

(I bloody hope so at least)



[COLOR=“Red”]

System Information[/COLOR]

CS-CART 1.3.4 SP2

Images kept via File System.

thickbox.zip