Cs-Cart And Multi-Vendor 4.15.1 Released

Any news on the future of Suppliers and Warehouses add ons?

Any news on the future of Suppliers and Warehouses add ons?

For the moment, no functionality changes are planned in 4.16.x for either of those add-ons. Although "Suppliers" will retain their "Deprecated" tag, they won't be removed just yet.

Version 4.16's main attraction will be new payment options for online stores and marketplaces through Stripe. Those payment options include Sofort, Klarna, Afterpay, Apple Pay, Google Pay, etc.

"Suppliers" will retain their "Deprecated" tag, they won't be removed just yet.

Curious if you sought the opinions of all the 3rd party add-on creators that make modules specific to Suppliers, I know there are many as I have bought quite a few of them

I'm pretty sure i've found a bug on PHP8 support on db abstraction.

1) app\Tygh\Lock\Store\DatabaseStore.php -> save() assumes a DatabaseException to work correctly.

2) app\Tygh\Database\Connection.php -> query() does throw a DatabaseException but it does not catch an already thrown one.

3) PDO default behavior before php8 was to not throw on errors, but starting from 8.0 it throws.

https://www.php.net/manual/en/pdo.error-handling.php

4) so app\Tygh\Lock\Store\DatabaseStore.php -> save() is getting a PDOException instead of DatabaseException and it does not work as it is supposed.

Possible fix

at app\Tygh\Backend\Database\Pdo.php

add $this->conn->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_SILENT); on line 53

Catch of DatabaseException is used on a few places, so I think it could be reproduced in other cases also.

Would love to get access to source code / repo and tests.... :grin:

Hi! Thanks for letting us know and even suggesting the fix. I've forwarded it to the developers, and they'll look into it at the earliest opportunity.

As for access to the repo, that might be more complicated. For the moment, there is a limited number of people who have that access. To my knowledge, that list includes some members of the CS-Cart staff, and some of the third-party developers (our partners) who create add-ons and post them at https://marketplace.cs-cart.com.

I'm pretty sure i've found a bug on PHP8 support on db abstraction.

1) app\Tygh\Lock\Store\DatabaseStore.php -> save() assumes a DatabaseException to work correctly.

2) app\Tygh\Database\Connection.php -> query() does throw a DatabaseException but it does not catch an already thrown one.

3) PDO default behavior before php8 was to not throw on errors, but starting from 8.0 it throws.

https://www.php.net/manual/en/pdo.error-handling.php

4) so app\Tygh\Lock\Store\DatabaseStore.php -> save() is getting a PDOException instead of DatabaseException and it does not work as it is supposed.

Possible fix

at app\Tygh\Backend\Database\Pdo.php

add $this->conn->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_SILENT); on line 53

Catch of DatabaseException is used on a few places, so I think it could be reproduced in other cases also.

Would love to get access to source code / repo and tests.... :grin:

Hi patroklos,

The fix will be included in release 4.15.2.
Patch: https://gist.github.com/ichaykin/b116fd9b39ca833a1d7e98e0442dac43


You can read about how to apply the patch in our documentation: https://docs.cs-cart..._diff_file.html

Hi,

Just a quick question related on that.

What is the purpose of the locking mechanism for files since you can just disable it

in the conf file?

Hi,

Just a quick question related on that.

What is the purpose of the locking mechanism for files since you can just disable it

in the conf file?

Hi, Patroklos!

The locks prevent a race condition and help to avoid increased server load when the cache is generated for the first time after cache clearing

OK thanks!

Is there already a date for when we can use this feature?
I only have credit cards available in Multi Vendor via Stripe Connect, which is very limited in 2022. :roll_eyes:

1 Like

Sorry, I can’t promise a specific date yet. The current estimate is the upcoming January.

We aim for at least a couple of big releases per year, so ideally we’d want to release it this December. But in addition to Stripe, version 4.16.1 will also include a better dashboard, with a configurable onboarding section for vendors. You can find more on that in the “Future plans” section here: What's New In Multi-Vendor

Where can I get a copy of the patch to process credit cards in admin?

Thanks
Ken

Here’s a link to the post where I shared the DIFF file: Cs-Cart And Multi-Vendor 4.14.3 Released - #10 by ikoshkin